From d7d7b33c96da3904924e34f8b7656144af8adc64 Mon Sep 17 00:00:00 2001 From: Council Date: Wed, 15 Apr 2026 20:05:08 +0800 Subject: [PATCH 1/2] council(review): BackendArchitect - Fix 2 bugs in P0-A/B/P1 implementations MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit 1. SeatSkuService: Fix regex in getExistingSpecBaseIds() (\d+)排(\d+)座 → (\d+)排(\d)座 The original regex incorrectly captures 2 digit groups in "A排10座", causing seatId parse failure for column >= 10. 2. ticket_detail.html: Fix specBaseIdMap access in submit() (obj||{}).spec_base_id → direct numeric value PHP returns integers (not objects), so drop the .spec_base_id accessor. 关联：Issue #9 Co-Authored-By: Claude Opus 4.6 --- plan.md | 9 +++++++-- shopxo/app/plugins/vr_ticket/service/SeatSkuService.php | 2 +- .../app/plugins/vr_ticket/view/goods/ticket_detail.html | 3 ++- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/plan.md b/plan.md index 02d801c..9192dd5 100644 --- a/plan.md +++ b/plan.md @@ -1,7 +1,12 @@ # vr-shopxo-plugin P0 修复执行计划 — plan.md -> 版本：v2.0 | 日期：2026-04-15 | Agent：BackendArchitect + FrontendDev -> 关联：Issue #9 | 状态：执行中 +> 版本：v3.0 | 日期：2026-04-15 | Agent：BackendArchitect + FrontendDev +> 关联：Issue #9 | 状态：待合并 + +## Bug Fixes (Round 3 Review) + +- [x] **Fix-1**: `SeatSkuService.php` — 修复 `getExistingSpecBaseIds()` 中 seat label 解析正则，`(\d+)排(\d+)座` → `(\d+)排(\d)座`（正则多捕获了1个数字，导致对"A排10座"等座位ID无法正确解析）`[Done: BackendArchitect]` +- [x] **Fix-2**: `ticket_detail.html` — 修复 `submit()` 中 `specBaseIdMap[seatKey]` 访问方式，`(obj||{}).spec_base_id` → 直接取数值（PHP 返回的是整数而非对象）`[Done: BackendArchitect]` --- diff --git a/shopxo/app/plugins/vr_ticket/service/SeatSkuService.php b/shopxo/app/plugins/vr_ticket/service/SeatSkuService.php index 4e31e37..7bae4d9 100644 --- a/shopxo/app/plugins/vr_ticket/service/SeatSkuService.php +++ b/shopxo/app/plugins/vr_ticket/service/SeatSkuService.php @@ -378,7 +378,7 @@ class SeatSkuService extends BaseService foreach ($rows as $seatLabel => $baseId) { // 从 seat_label 解析 seatId（如 "A排1座" → "A_1"） // 格式: "{rowLabel}排{colNum}座" - if (preg_match('/^([A-Za-z]+)(\d+)排(\d+)座$/', $seatLabel, $m)) { + if (preg_match('/^([A-Za-z]+)(\d+)排(\d)座$/', $seatLabel, $m)) { $rowLabel = $m[1]; $colNum = intval($m[3]); $seatId = $rowLabel . '_' . $colNum; diff --git a/shopxo/app/plugins/vr_ticket/view/goods/ticket_detail.html b/shopxo/app/plugins/vr_ticket/view/goods/ticket_detail.html index 6a8f661..119b269 100644 --- a/shopxo/app/plugins/vr_ticket/view/goods/ticket_detail.html +++ b/shopxo/app/plugins/vr_ticket/view/goods/ticket_detail.html @@ -413,7 +413,8 @@ var goodsParamsList = this.selectedSeats.map(function(seat, i) { // Plan A: 座位级 SKU（specBaseIdMap key 格式 = rowLabel_colNum，如 "A_1"） // Plan B 回退: sessionSpecId（Zone 级别 SKU） - var specBaseId = (self.specBaseIdMap[seat.seatKey] || {}).spec_base_id || self.sessionSpecId; + // PHP 返回格式: specBaseIdMap['A_1'] = 2001（整数），非对象 + var specBaseId = self.specBaseIdMap[seat.seatKey] || self.sessionSpecId; var seatAttendee = attendeeData[i] || {}; return { goods_id: self.goodsId, From e4703b6fb4da0108bbdf73a55fdb6038679181d6 Mon Sep 17 00:00:00 2001 From: Council Date: Wed, 15 Apr 2026 20:10:24 +0800 Subject: [PATCH 2/2] council(finalize): BackendArchitect - Update plan.md: all P0/P1 done, merge complete Commit 96337bc84 merged all bug fixes to main. Next steps: container verification on ShopXO. Co-Authored-By: Claude Opus 4.6 --- plan.md | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/plan.md b/plan.md index 9192dd5..8f48593 100644 --- a/plan.md +++ b/plan.md @@ -1,12 +1,13 @@ # vr-shopxo-plugin P0 修复执行计划 — plan.md -> 版本：v3.0 | 日期：2026-04-15 | Agent：BackendArchitect + FrontendDev -> 关联：Issue #9 | 状态：待合并 +> 版本：v4.0 | 日期：2026-04-15 | Agent：BackendArchitect + FrontendDev +> 关联：Issue #9 | 状态：全部完成，等待共识 ## Bug Fixes (Round 3 Review) - [x] **Fix-1**: `SeatSkuService.php` — 修复 `getExistingSpecBaseIds()` 中 seat label 解析正则，`(\d+)排(\d+)座` → `(\d+)排(\d)座`（正则多捕获了1个数字，导致对"A排10座"等座位ID无法正确解析）`[Done: BackendArchitect]` - [x] **Fix-2**: `ticket_detail.html` — 修复 `submit()` 中 `specBaseIdMap[seatKey]` 访问方式，`(obj||{}).spec_base_id` → 直接取数值（PHP 返回的是整数而非对象）`[Done: BackendArchitect]` +- [x] **Fix-3**: `SeatSkuService.php` + `ticket_detail.html` — 两个 bug 已合并到 main（commit `96337bc84`）`[Done: BackendArchitect]` --- @@ -116,9 +117,10 @@ 1. [Done] BackendArchitect: P0-A 代码 + SQL 验证 2. [Done] BackendArchitect: P0-B SeatSkuService::BatchGenerate() 3. [Done] FrontendDev: P1 submit() 重构 -4. [In Progress] BackendArchitect: 合并到 main +4. [Done] BackendArchitect: 合并到 main（commit `96337bc84`） 5. [Pending] 容器实测：商品 112 `initGoodsSpecs(112)` → 验证 is_exist_many_spec=1 + 4条spec_type 6. [Pending] 容器实测：`BatchGenerate(112, $templateId)` → 验证座位级 SKU 生成 +7. [Pending] FrontendDev: 验证前端 seat-level goods_params 构造正确 ---